DJC hotfix's fix pr of the fix pr's fix pr #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Who are you?" |
|
Download the artifacts for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry (forces dj aerials to inherit the movement arc before allowing cancels)
accidentally undid it oops
peachassets-1.zip
fixes (from first impl):
-unnecessary hitstop check during exec
-delaying check until frame 2 of aerial
-peach dj frames (changed bc i failed to realise the above issue)
note for what this does exactly:
-force djc to experience at least 1f of dj arc
-checks for cancel AFTER 2nd motion is added
-it doesn't run the check during hitstop
this combined makes it perform more accurately, but still loses more height with tapjump. no issues were noticed on other characters but could be limited to only ness/lucas if they arise